Here are a few guidelines:
For general how-to and other non-issues, please use Slack instead of GitHub issues.
linkNew Feature or Bug
If you think you have found a bug or a new idea for a feature, please make sure that it has not already been reported or fixed If you have searched through all the existing issues and yours has not been reported, follow these next steps.
For code issues, please include:
- React version
- Browser and browser version
- Device type (phone, desktop, tablet, etc)
When you can, please provide images, videos, or gifs to help explain the issue. This will save me time on figuring out what the issue is. When there is a new feature, please give example use cases and a detailed description or point to the Material Design spec.
linkCreating a new Issue
Please create the ticket with the format:
[ComponentName] - Descriptive Title. This will make
searching for component related issues easier and help me group related bugs/features together.
[Autocomplete] - The Autocomplete does not do ajax calls for me The `Autocomplete` is a neat component, but it doesn't actually fetch data from the server for me when the user types. This would be a cool feature because of X, Y, and sometimes Z.Text
Please keep your pull requests small and focused on a single issue. This will help with the code review process and made it more likely to be accepted.
I am currently using a branching model where
masteronly gets updated when a new
npm publishoccurs. The active branch will be whatever version number that is currently being developed with an
x. So if the next release is
v1.0.1, the active development branch will be
Before you can do any work, make sure to fork the
react-mdrepository via GitHub and then you can follow these steps.
$ git clone https://github.com/<YOUR_USERNAME>/react-md $ cd react-md && yarnBash
If you have an existing local repository, please update it before you start to limit merge conflicts.
$ cd react-md $ git remote add upstream https://github.com/mlaursen/react-md # checkout the current release branch # so if you want to work on v1.0.1 $ git checkout release/1.0.x $ git fetch upstream release/1.0.x $ git rebase $ git checkout -b bugfix/My-Topic-Branch $ yarnBash
The raw source files will be in the
Please follow the linting rules in
.eslintrc. You can check or hopefully fix all problems with the following commands.
$ npm run lint # basic lint with warnings or errors $ npm run lint:fix # attempts to automatically fix problemsBash
The documentation website uses react-docgen. If you add a new property, component, or new functionality to an existing property, please update or add the docgen.
Please make sure to create new tests for any new features or bugfixes and prevent existing tests from failing.
$ npm run test # runs all the tests $ npm run test:watch # watches for changes in tests and rerunsBash
If there are any visual changes or you want to test the functionality of a component, you can use the documentation site and create a new example.
See the documentation's site README for information on running the dev server.
By contributing your code to to the
mlaursen/react-mdGitHub repository, you agree to license your contribution under the MIT License.